Add specifier unique identifier to TIFA and syntactic assertion feedbacks#164
Draft
Copilot wants to merge 2 commits into
Draft
Add specifier unique identifier to TIFA and syntactic assertion feedbacks#164Copilot wants to merge 2 commits into
specifier unique identifier to TIFA and syntactic assertion feedbacks#164Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/pedal-edu/pedal/sessions/0c83fb0a-f66e-4616-9d5d-01750ba3bd98 Co-authored-by: acbart <897227+acbart@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add unique identifier for all FF
Add Apr 23, 2026
specifier unique identifier to TIFA and syntactic assertion feedbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pedal's
Feedbackclass had aspecifierfield defined (with documentation) to uniquely identify feedback instances by their conditions — but TIFA and syntactic assertion feedbacks never populated it, making the field useless for those tool categories.Changes
pedal/tifa/feedbacks.pyAll TIFA feedback classes now set
self.specifierbefore callingsuper().__init__():specifier = name— coversunused_variable,initialization_problem,overwritten_variable,read_out_of_scope,recursive_call,incorrect_arity,parameter_type_mismatch, and othersspecifier = str(location)— coversaction_after_return,unconnected_blocks,type_change_append, etc.incompatible_types:specifier = op_name(the operation description, e.g."addition")recursive_call: extractsname.namesince the caller passes aStateobject rather than a plain stringpedal/assertions/syntactic.pyRequireAssertionFeedback/RejectAssertionFeedback:specifier = codereject_code_regex/require_code_regex:specifier = patterntests/test_tifa.pyAdded
TestSpecifierswith 15 tests verifying specifier values across the main TIFA feedback types: